[darwin]: wrap library functions as struct methods#1976
Merged
shirou merged 1 commit intoshirou:masterfrom Dec 28, 2025
Merged
Conversation
uubulb
force-pushed
the
refactor/wrap-library-functions
branch
2 times, most recently
from
eb1bc40 to
df90dba
Compare
uubulb
force-pushed
the
refactor/wrap-library-functions
branch
from
df90dba to
edba8ea
Compare
shirou
approved these changes
Dec 28, 2025
Owner
shirou
left a comment
shirou
left a comment
There was a problem hiding this comment.
Good refactoring. LGTM! Thank you so much.
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraryis now a private struct, used to compose new structs representing different system libraries/frameworks:CoreFoundationLib,IOKitLib, andSystemLib. Each of them provides public methods that directly register and call the underlying library functions, improving readability by eliminating the need to useGetFuncin other packages.A temporary cache
fnMapis added to theLibrarystruct to ensure the same lazy loading behavior as before.Note: This PR contains changes from #1971 and #1973, so it has lower review priority than those. These changes are included here to make upcoming conflict fixing easier.